Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating export-docs #2156

Merged
merged 11 commits into from
Nov 30, 2020
Merged

Updating export-docs #2156

merged 11 commits into from
Nov 30, 2020

Conversation

eddynaka
Copy link
Collaborator

Fixes #2155

Changes:

  • updating multitool parameters in alphabetical order
  • enabling export-docs to accept list of assemblies that implement ReportingDescriptor

@eddynaka eddynaka changed the base branch from master to main November 20, 2020 18:42
michaelcfanning
michaelcfanning reviewed Nov 30, 2020
View reviewed changes
src/ReleaseHistory.md Outdated
@@ -2,6 +2,7 @@

## **Unreleased**
* FEATURE: Multitool SARIF rewrite accepts `remove` parameter[#2160](https://github.com/microsoft/sarif-sdk/pull/2160)
* BREAKING: Remove command `export-validation-docs` and add `export-validation-rules` command can export markdown file [#2156](https://github.com/microsoft/sarif-sdk/pull/2156)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove command export-validation-docs and add export-validation-rules command can export markdown file #2156 [](start = 12, length = 164)

Remove command export-validation-docs and extend export-validation-rules command to export markdown file #2156

michaelcfanning
michaelcfanning approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eddynaka eddynaka merged commit 8a0b057 into main Nov 30, 2020
@eddynaka eddynaka deleted the users/ednakamu/expanding-export-docs branch November 30, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcfanning michaelcfanning michaelcfanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

export-validation-docs should accept another binary
2 participants
@eddynaka @michaelcfanning