Accepting relative URLs #2235
Merged
Accepting relative URLs #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Sarif/RuleUtilities.cs
Outdated
| { | ||
| result.Locations = new List<Location> { | ||
| new Sarif.Location { | ||
| PhysicalLocation = new PhysicalLocation | ||
| { | ||
| ArtifactLocation = new ArtifactLocation | ||
| { | ||
| Uri = new Uri(targetPath) | ||
| Uri = context.TargetUri.IsAbsoluteUri ? new Uri(context.TargetUri.LocalPath) : context.TargetUri |
There was a problem hiding this comment.
Uri [](start = 77, length = 3)
why can't we reuse context.TargetUri here?
| @@ -173,7 +175,8 @@ public static string GetFileName(this Uri uri) | |||
| { | |||
| if (!uri.IsAbsoluteUri) | |||
| { | |||
| throw new InvalidOperationException(); | |||
| var newAbsoluteUri = new Uri(BaseUri, uri.OriginalString); | |||
| return Path.GetFileName(newAbsoluteUri.LocalPath); | |||
There was a problem hiding this comment.
GetFileName [](start = 28, length = 11)
make sure this works with a path like \blah.txt and blah.txt (no prefixed slash). #Closed
src/Sarif/ExtensionMethods.cs
Outdated
| @@ -16,6 +16,8 @@ namespace Microsoft.CodeAnalysis.Sarif | |||
| { | |||
| public static class ExtensionMethods | |||
| { | |||
| private static readonly Uri BaseUri = new Uri("https://github.com/microsoft/sarif-sdk/"); | |||
|
|
|||
There was a problem hiding this comment.
use https://example.com here (and provide a comment). actually! how about declaring this as an inlined string const in your helper? #Closed
…b.com/microsoft/sarif-sdk into users/ednakamu/accepting-relative-url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.