Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing null reference in SARIF1012 validation #2254

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Fixing null reference in SARIF1012 validation #2254

merged 4 commits into from
Jan 22, 2021

Conversation

eddynaka
Copy link
Collaborator

Changes

  • When we have a result without message arguments and the rule contains arguments, we were causing a null reference, since we were trying to get the actual count of arguments that the result had. With that, if arguments are null, the count is zero.

michaelcfanning
michaelcfanning approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@michaelcfanning michaelcfanning enabled auto-merge (squash) January 22, 2021 22:36
@michaelcfanning michaelcfanning merged commit 6bd5d8d into main Jan 22, 2021
@michaelcfanning michaelcfanning deleted the users/ednakamu/fixing-null-reference branch January 22, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcfanning michaelcfanning michaelcfanning approved these changes

@jameswinkler jameswinkler Awaiting requested review from jameswinkler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddynaka @michaelcfanning