Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving memory usage #2301

Merged
merged 2 commits into from
Feb 28, 2021
Merged

Improving memory usage #2301

merged 2 commits into from
Feb 28, 2021

Conversation

eddynaka
Copy link
Collaborator

For a specific run, I observed that we were caching results that weren't need based on the level/kind.

Before:
image

After:
image

During the first 40 seconds, I could see the number of objects increasing:

Before:
image

After:
image

michaelcfanning
michaelcfanning approved these changes Feb 28, 2021
View reviewed changes
Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eddynaka eddynaka enabled auto-merge (squash) February 28, 2021 18:19
@eddynaka eddynaka merged commit 7262308 into main Feb 28, 2021
@eddynaka eddynaka deleted the users/ednakamu/improving-memory-usage branch February 28, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcfanning michaelcfanning michaelcfanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddynaka @michaelcfanning