Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing ResultLevelKind #2331

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Exposing ResultLevelKind #2331

merged 2 commits into from
Apr 16, 2021

Conversation

eddynaka
Copy link
Collaborator

No description provided.

michaelcfanning
michaelcfanning reviewed Apr 16, 2021
View reviewed changes
src/Sarif/Core/ResultLevelKind.cs Outdated

return resultKind.Value;
}
set { resultKind = value; }
Copy link
Member

@michaelcfanning michaelcfanning Apr 16, 2021 •
edited by eddynaka
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resultKind = value

If someone sets a kind that isn't 'Fail', you should clear Level. Right? #Closed

michaelcfanning
michaelcfanning reviewed Apr 16, 2021
View reviewed changes
src/Sarif/Core/ResultLevelKind.cs Outdated
set { resultKind = value; }
}

public FailureLevel Level { get; set; }
Copy link
Member

@michaelcfanning michaelcfanning Apr 16, 2021 •
edited by eddynaka
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set

If someone sets this value to non-zero, you should slam 'Fail' into the Kind property or perhaps just set it to null so that the default gets picked up in its setter. #Closed

michaelcfanning
michaelcfanning approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@michaelcfanning michaelcfanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@eddynaka eddynaka enabled auto-merge (squash) April 16, 2021 21:14
@eddynaka eddynaka merged commit 68818c0 into main Apr 16, 2021
@eddynaka eddynaka deleted the users/ednakamu/exposing-resultlevelkind branch April 16, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcfanning michaelcfanning michaelcfanning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eddynaka @michaelcfanning