Flowing suppression to baseline #2390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddynaka
commented
Oct 4, 2021
|
|
||
| SarifLog currentSarifLog = PrereleaseCompatibilityTransformer.UpdateToCurrentVersion(fileSystem.FileReadAllText(options.OutputFilePath), | ||
| options.Formatting, | ||
| out string _); |
There was a problem hiding this comment.
this will enable us to accept any version.
eddynaka
commented
Oct 4, 2021
| @@ -3,11 +3,8 @@ | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.Sarif.Driver | |||
| { | |||
| public abstract class DriverCommand<T> | |||
| public abstract class DriverCommand<T> : CommandBase | |||
eddynaka
commented
Oct 7, 2021
| if (PreviousResult.Result.Suppressions != null && CurrentResult.Result.Suppressions == null) | ||
| { | ||
| result.Suppressions = PreviousResult.Result.Suppressions; | ||
| } |
There was a problem hiding this comment.
this will flow suppressions from the baseline file to the current file. #Resolved
There was a problem hiding this comment.
so here we don't consider current file's suppression?
There was a problem hiding this comment.
Since we start from the current, we just have to compare previous with current. if previous exist and current does not, we should replace.
otherwise, we will keep the current :)
eddynaka
deleted the
users/ednakamu/suppression-should-flow-to-baseline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.