Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SarifLogger now emits an artifacts table entry if artifactLocation is not null for tool configuration and tool execution notifications. #2437

Merged
merged 3 commits into from
Feb 1, 2022
Merged

SarifLogger now emits an artifacts table entry if artifactLocation is not null for tool configuration and tool execution notifications. #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
389c1fb
Fixing artifacts generation when logging notifications
eddynaka Feb 1, 2022
629c83d
Updating release history.
eddynaka Feb 1, 2022
46d0650
Updating ReleaseHistory
eddynaka Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ReleaseHistory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* BREAKING: `AnalyzeCommandBase` previously persisted all scan target artifacts to SARIF logs rather than only persisting artifacts referenced by an analysis result, when an option to persist hashes, text file or binary information was set. `MultithreadedAnalyzeCommandBase` previously persisted all scan targets artifacts to SARIF logs in cases when hash insertion was eenabled rather than only persisting artifacts referenced by an analysis result. [#2433](https://github.com/microsoft/sarif-sdk/pull/2433)
* BUGFIX: Adjust Json Serialization field order for ReportingDescriptor and skip emit empty AutomationDetails node. [#2420](https://github.com/microsoft/sarif-sdk/pull/2420)
* BREAKING: Fix `InvalidOperationException` when using PropertiesDictionary in a multithreaded application, and remove `[Serializable]` from it. Now use of BinaryFormatter on it will result in `SerializationException`: Type `PropertiesDictionary` is not marked as serializable. [#2415](https://github.com/microsoft/sarif-sdk/pull/2415)
* BREAKING: `SarifLogger` now emits an artifacts table entry if `artifactLocation` is not null for tool configuration and tool execution notifications. [#2437](https://github.com/microsoft/sarif-sdk/pull/2437)

## **v2.4.12** [Sdk](https://www.nuget.org/packages/Sarif.Sdk/2.4.12) | [Driver](https://www.nuget.org/packages/Sarif.Driver/2.4.12) | [Converters](https://www.nuget.org/packages/Sarif.Converters/2.4.12) | [Multitool](https://www.nuget.org/packages/Sarif.Multitool/2.4.12) | [Multitool Library](https://www.nuget.org/packages/Sarif.Multitool.Library/2.4.12)

Expand Down
18 changes: 18 additions & 0 deletions src/Sarif/Writers/SarifLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,8 @@ public void LogToolNotification(Notification notification)
_run.Invocations[0].ToolExecutionNotifications = _run.Invocations[0].ToolExecutionNotifications ?? new List<Notification>();
_run.Invocations[0].ToolExecutionNotifications.Add(notification);
_run.Invocations[0].ExecutionSuccessful &= notification.Level != FailureLevel.Error;

CaptureFilesInNotification(notification);
}

public void LogConfigurationNotification(Notification notification)
Expand All @@ -493,6 +495,22 @@ public void LogConfigurationNotification(Notification notification)
_run.Invocations[0].ToolConfigurationNotifications = _run.Invocations[0].ToolConfigurationNotifications ?? new List<Notification>();
_run.Invocations[0].ToolConfigurationNotifications.Add(notification);
_run.Invocations[0].ExecutionSuccessful &= notification.Level != FailureLevel.Error;

CaptureFilesInNotification(notification);
}

private void CaptureFilesInNotification(Notification notification)
{
if (notification.Locations != null)
{
foreach (Location location in notification.Locations)
{
if (location.PhysicalLocation != null)
{
CaptureArtifact(location.PhysicalLocation.ArtifactLocation);
}
}
}
}

private static string Redact(string text, IEnumerable<string> tokensToRedact)
Expand Down
Loading