Update MSBuild Converter regex to support more MSBuild log variants #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongyan-gh
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
shaopeng-gh
reviewed
Nov 22, 2022
| <None Remove="TestData\MSBuildConverter\ExpectedOutputs\ValidResults.sarif" /> | ||
| <None Remove="TestData\MSBuildConverter\Inputs\Empty.ERR" /> | ||
| <None Remove="TestData\MSBuildConverter\Inputs\InvalidResult.ERR" /> | ||
| <None Remove="TestData\MSBuildConverter\Inputs\ValidResults.ERR" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
fyi I remember Michael once had a comment about removing the whole <ItemGroup> instead, if all of the content is not needed, see if applies here. #Resolved
shaopeng-gh
reviewed
Nov 22, 2022
| @@ -83,9 +84,9 @@ private IList<Result> GetResults(TextReader reader) | |||
| \s*:\s* | |||
| (?<qualifiedLevel> | |||
| (?<levelQualification>.*) # For example, 'fatal'. | |||
| (?<level>error|warning|note|info|pass|review|open|notapplicable) | |||
| (?<level>error|err|warning|wrn|note|info|pass|review|open|notapplicable) | |||
There was a problem hiding this comment.
Don't see a definition of what the level should be in .ERR file. Have seen "Error"/"Warning" also the abbreviation forms "ERR"/"WRN" in build logs. Here just try to match the keyword as much as possible
shaopeng-gh
reviewed
Nov 22, 2022
| } | ||
| }, | ||
| { | ||
| "ruleId": "PV1002", |
|
For testing the regex: |
shaopeng-gh
reviewed
Nov 22, 2022
src/ReleaseHistory.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * BUGFIX: Update `merge` command to properly produce runs by tool and version when passed the `--merge-runs` argument. [#2488](https://github.com/microsoft/sarif-sdk/pull/2488) | |||
| * BUGFIX: Eliminate `IOException` and `DirectoryNotFoundException` exceptions thrown by `merge` command when splitting by rule (due to invalid file characters in rule ids). [#2513](https://github.com/microsoft/sarif-sdk/pull/2513) | |||
| * BUGFIX: Fix classes inside NotYetAutoGenerated folder missing `virtual` keyword for public methods and properties, by regenerate and manually sync the changes. [#2537](https://github.com/microsoft/sarif-sdk/pull/2537) | |||
| * BUGFIX: MSBuild Converter accepts case insensitive keywords and supports PackageValidator msbuild log. [#2579](https://github.com/microsoft/sarif-sdk/pull/2579) | |||
src/ReleaseHistory.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * BUGFIX: Update `merge` command to properly produce runs by tool and version when passed the `--merge-runs` argument. [#2488](https://github.com/microsoft/sarif-sdk/pull/2488) | |||
| * BUGFIX: Eliminate `IOException` and `DirectoryNotFoundException` exceptions thrown by `merge` command when splitting by rule (due to invalid file characters in rule ids). [#2513](https://github.com/microsoft/sarif-sdk/pull/2513) | |||
| * BUGFIX: Fix classes inside NotYetAutoGenerated folder missing `virtual` keyword for public methods and properties, by regenerate and manually sync the changes. [#2537](https://github.com/microsoft/sarif-sdk/pull/2537) | |||
| * BUGFIX: MSBuild Converter accepts case insensitive keywords and supports PackageValidator msbuild log. [#2579](https://github.com/microsoft/sarif-sdk/pull/2579) | |||
There was a problem hiding this comment.
thanks for the suggestion. updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The information regarding MSBuild log format https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-diagnostic-format-for-tasks?view=vs-2022