BUGFIX : Resolve hangs due to unhandled exceptions during multithreaded analysis file hashing phase. #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaopeng-gh
requested review from
michaelcfanning,
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
shaopeng-gh
commented
Dec 29, 2022
| @@ -882,6 +882,45 @@ public void MultithreadedAnalyzeCommandBase_TargetFileSizeTestCases() | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void MultithreadedAnalyzeCommandBase_ErrorWhenHashing() | |||
shaopeng-gh
commented
Dec 29, 2022
| finally | ||
| { | ||
| readyToScanChannel.Writer.Complete(); | ||
| } |
There was a problem hiding this comment.
used the same code for enumeration phase.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+559
to
+563
| catch (Exception e) | ||
| { | ||
| Errors.LogUnhandledEngineException(_rootContext, e); | ||
| ThrowExitApplicationException(_rootContext, ExitReason.UnhandledExceptionInEngine); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
michaelcfanning
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exception happens, below 2 lines will not run:
I can reproduce this when debugging below line will be waiting, not ending at all: