Add rolling has optional data enum value. Remove SarifLogger tool parameter. #2614
Conversation
michaelcfanning
requested review from
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
|
The OptionallyEmittedData.RollingHashPartialFingerprints flag doesn't seem to be referenced anywhere yet. Is that postponed to a future PR or am I just not looking at the right place? |
|
That's correct, not yet wired up. The plan is to integrate this with the FileRegionsCache, following the same pattern as handling the new line indices in that type. We have a large-scale pipeline design change coming that might lead us to reconsider all hash production, though, which is why I delayed the work. In reply to: 1412629616 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return ComputeHashes(stream); | ||
| } | ||
| } | ||
| catch (IOException) { } |
Check notice
Code scanning / CodeQL
Poor error handling: empty catch block
| } | ||
| } | ||
| catch (IOException) { } | ||
| catch (UnauthorizedAccessException) { } |
Check notice
Code scanning / CodeQL
Poor error handling: empty catch block
No description provided.