Update pipeline for multithreaded analysis. #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcfanning
requested review from
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
michaelcfanning
commented
Feb 27, 2023
| @@ -53,7 +53,7 @@ public virtual IEnumerable<IOption> GetOptions() | |||
| public virtual IEnumeratedArtifact CurrentTarget { get; set; } | |||
| public virtual string MimeType { get; set; } | |||
| public virtual HashData Hashes { get; set; } | |||
| public virtual Exception RuntimeException { get; set; } | |||
| public virtual IList<Exception> RuntimeExceptions { get; set; } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change deprecates a duplicative single exception for runtime failures expressed as
MulthreadedAnalyzeCommandBase.EngineExceptionandIAnalysisContext.RuntimeException, in favor of a new property,IAnalysisContext.RuntimeExceptions, that can hold multiple exceptions.This allows for tracking errors across multiple threads, e.g., an unhandled exception in a rule as well as a timeout exception.
Otherwise, this change cleans up error handling in the core threading model.