Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If HDF CodeDesc is empty, use Desc as Message #2632

Closed
wants to merge 1 commit into from

Conversation

candrews
Copy link
Collaborator

@candrews candrews commented Mar 3, 2023

Sometimes, the HDF CodeDesc is empty. Currently, that results in the SARIF Message being set to "." which isn't good.

To fix that issue, if CodeDesc is empty, use the Desc.

I've reported one case where the HDF code_desc is set to the empty string at mitre/saf#1163

Sometimes, the HDF CodeDesc is empty. Currently, that results in the SARIF Message being set to "." which isn't good.

To fix that issue, if CodeDesc is empty, use the Desc.
@michaelcfanning
Copy link
Member

ok! this makes sense as a mitigation, particularly as you have done the due diligence of pursuing an upstream solution to the root problem. :)

if you will create a branch off main with your change and update the release note with an appropriate summary of the goodness, we will approve and merge.

thanks for the contribution!

@candrews
Copy link
Collaborator Author

candrews commented Mar 3, 2023

ok! this makes sense as a mitigation, particularly as you have done the due diligence of pursuing an upstream solution to the root problem. :)

Fantastic! That's my sentiment precisely :)

if you will create a branch off main with your change and update the release note with an appropriate summary of the goodness, we will approve and merge.

I've submitted a new PR as you described: #2635

thanks for the contribution!

You're welcome!

@candrews candrews closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants