Target analysis completed #2637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcfanning
commented
Mar 7, 2023
| var context = new TestAnalysisContext | ||
| { | ||
| Logger = logger, | ||
| MaxFileSizeInKilobytes = long.MaxValue, |
michaelcfanning
commented
Mar 7, 2023
| @@ -242,7 +242,7 @@ public virtual TContext InitializeContextFromOptions(TOptions options, ref TCont | |||
| context.ResultKinds = options.ResultKinds; | |||
| context.FailureLevels = options.FailureLevels; | |||
| context.OutputFileOptions = options.OutputFileOptions.ToFlags(); | |||
| context.MaxFileSizeInKilobytes = options.MaxFileSizeInKilobytes; | |||
| context.MaxFileSizeInKilobytes = options.MaxFileSizeInKilobytes != null ? options.MaxFileSizeInKilobytes.Value : context.MaxFileSizeInKilobytes; | |||
michaelcfanning
requested review from
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
…oft/sarif-sdk into target-analysis-completed
cfaucon
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary point of this PR is to restore callbacks to
IAnalysisLogger.AnalyzingTargetimplementations (removed in recent pipeline rewrite). While the hood is up, added a newIAnalysisLogger.TargetAnalyzedcallback.AnalyzingTargetis called from the target enumeration thread. Strictly speaking, this isn't when analysis begins. The scan threads do not have a pointer to the global context logger, however, so changing this would require more thought.TargetAnalyzedis called from the logging thread and so synchronization is required again on the global context object.As part of this change, I noticed some console logger messages that never fired (because the callback wasn't executed) tracking the start of analysis. This is verbose logging, so I put it behind a new trace flag (and added analogous handling in the target analyzed callback).
@eddynaka @suvamM @shaopeng-gh @easyrhino-gh @cfaucon