Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console logger etc. #2647

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Console logger etc. #2647

merged 4 commits into from
Mar 22, 2023

Conversation

michaelcfanning
Copy link
Member

@michaelcfanning michaelcfanning commented Mar 22, 2023 •
edited
Loading

  • BRK: Command-line argument automationGuid renamed to automation-guid. #2647
  • BRK: Command-line argument automationId renamed to automation-id. #2647

michaelcfanning
michaelcfanning commented Mar 22, 2023
View reviewed changes
src/Sarif/AnalyzeContextBase.cs
@@ -207,6 +216,11 @@ public virtual void Dispose()
"CoreSettings", nameof(OutputFilePath), defaultValue: () => string.Empty,
"The path to write all SARIF log file results to.");

public static PerLanguageOption<string> PostUriProperty { get; } =
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostUriProperty

This kind of change allows this data to be read from/written to our XML driven configuration.

michaelcfanning
michaelcfanning commented Mar 22, 2023
View reviewed changes
src/Sarif.Driver/Sdk/MultithreadedAnalyzeCommandBase.cs
// We initialize an aggregating logger, which includes a console logger (for general
// reporting of conditions that precede successfully creating an output log file).
context.Logger ??= InitializeLogger(context);
// We initialize a temporary console logger that's used strictly to emit
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initialize

The previous interim release would always set the console logger to default values, rather than honoring config or explicitly command-line configured values.

michaelcfanning
michaelcfanning commented Mar 22, 2023
View reviewed changes
src/Sarif.Driver/Sdk/CommonOptionsBase.cs
@@ -101,12 +101,12 @@ internal static IEnumerable<FilePersistenceOptions> NormalizeFilePersistenceOpti
public IEnumerable<string> InsertProperties { get; set; }

[Option(
"automationId",
"automation-id",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automation

these aren't highly utilized, otherwise we might ship a release where they are marked as obsolete.

@michaelcfanning michaelcfanning marked this pull request as ready for review March 22, 2023 22:03
@michaelcfanning michaelcfanning merged commit 1ff3956 into main Mar 22, 2023
@michaelcfanning michaelcfanning deleted the console-logger-etc branch March 22, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EasyRhinoMSFT EasyRhinoMSFT Awaiting requested review from EasyRhinoMSFT EasyRhinoMSFT is a code owner

@marmegh marmegh Awaiting requested review from marmegh

@cfaucon cfaucon Awaiting requested review from cfaucon cfaucon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaelcfanning