Fix broken regex in 'language' property. #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcfanning
requested review from
EasyRhinoMSFT,
marmegh and
cfaucon
as code owners
|
@shaopeng-gh @EasyRhinoMSFT just a heads up. |
|
@michaelcfanning - note that this fixes line 3063 but the same fix also needs to be applied to line 2357. |
|
@michaelcfanning - bump to make sure you are aware that the schemata are now internally inconsistent. This closed PR fixed line 3063, but line 2357 still needs the same fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source discussion: oasis-tcs/sarif-spec#562
@rwoll @EasyRhinoMSFT @shaopeng-gh