HdfConverter: SARIF location improvements - #2704
Merged
Merged
Conversation
Signed-off-by: Craig Andrews <candrews@integralblue.com>
Signed-off-by: Craig Andrews <candrews@integralblue.com>
Craig Andrews (candrews)
requested review from
Chris Meyer (EasyRhinoMSFT),
cfaucon,
marmegh and
Michael C. Fanning (michaelcfanning)
as code owners
July 28, 2023 02:21
GitHub Advanced Security code scanning requires 'physicalLocation.artifactLocation.uri' to have a non-empty string value. Signed-off-by: Craig Andrews <candrews@integralblue.com>
Craig Andrews (candrews)
force-pushed
the
sarif-location
branch
from
July 28, 2023 02:51
4ffc769 to
942cc0e
Compare
Collaborator
Author
|
Michael C. Fanning (@michaelcfanning) could you please take a look at this when you get a chance? |
Contributor
|
Will jump on this today or tomorrow, sorry for the delay. |
Collaborator
Author
Thank you again for working with me on this project! If you have any questions about this or #2705 I look forward to promptly addressing them. |
Collaborator
Author
|
Michael C. Fanning (@michaelcfanning) could you please take a look? Thank you again! |
Michael C. Fanning (michaelcfanning)
suggested changes
Aug 23, 2023
Michael C. Fanning (michaelcfanning)
left a comment
Michael C. Fanning (michaelcfanning)
left a comment
Contributor
There was a problem hiding this comment.
🕐
Michael C. Fanning (michaelcfanning)
approved these changes
Aug 23, 2023
Michael C. Fanning (michaelcfanning)
left a comment
Michael C. Fanning (michaelcfanning)
left a comment
Contributor
There was a problem hiding this comment.
Michael C. Fanning (michaelcfanning)
approved these changes
Aug 23, 2023
Michael C. Fanning (michaelcfanning)
enabled auto-merge (squash)
August 23, 2023 18:55
Michael C. Fanning (michaelcfanning)
disabled auto-merge
August 23, 2023 19:01
Contributor
|
Sorry for the egregious delay here, dropped the ball initially on review and then went out of town. :( |
Contributor
|
Updated your release notes and will now merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://github.com/mitre/heimdall2/blob/v2.6.59/libs/inspecjs/src/generated_parsers/v_1_0/exec-json.ts#L311
Michael C. Fanning (@michaelcfanning) The validator at https://sarifweb.azurewebsites.net/Validation only checks that
uriis present, it doesn't complain whenuriis set to empty string. However, GitHub does complain, failing withlocationFromSarifResult: expected artifact locationas shown at https://github.com/candrews/jumpstart/actions/runs/5684090175/job/15406260757?pr=884#step:10:23How can I contact whoever runs https://sarifweb.azurewebsites.net/Validation to tell them that it should report a problem when
physicalLocation.artifactLocation.uri=""?