Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer does not handle SARIF with multiple runs that have same file paths in different runs #30

Closed
cfaucon opened this issue Sep 4, 2018 · 0 comments
Closed

Viewer does not handle SARIF with multiple runs that have same file paths in different runs #30

cfaucon opened this issue Sep 4, 2018 · 0 comments
Assignees
@EasyRhinoMSFT
Labels
bug Something isn't working

Comments

@cfaucon
Copy link

cfaucon commented Sep 4, 2018 •
edited

Repro Steps:

  1. Attempt to open the attach SARIF in the viewer (rename attachment to .sarif)

Expected: SARIF should load into viewer error list as normal
Actual: Exception thrown due to key already existing in dictionary
image

AndroidStudio.sarif.txt
@EasyRhinoMSFT EasyRhinoMSFT self-assigned this Nov 13, 2018
@EasyRhinoMSFT EasyRhinoMSFT added the bug Something isn't working label Nov 13, 2018
michaelcfanning pushed a commit that referenced this issue Jan 12, 2019
@EasyRhinoMSFT @michaelcfanning
Fix #6 #26 #29 #30 #63 (#64)
b4a3d39 
* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes
EasyRhinoMSFT added a commit that referenced this issue Mar 20, 2019
@EasyRhinoMSFT
Merge develop into master (#74)
3918570 
* Fix #41, #48, #49 (#52)

* Fix #28 and #46 error list item text (#51)

* Tinkering

* Fix #28 and #46

* Use VS 'category' column for result baseline state, if present (#62)

* Fix #28 and #56 (#59)

* Fix #28 and #56

* Add unit tests

* Revamp Stacks view (#61)

* Update Stacks UI, add VS-styled ComboBox template

* Add double-click navigate to stack frame location

* ListView color corrections

* Remove serializer settings object

* PR feedback

* Fix #6 #26 #29 #30 #63 (#64)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix #3 #4 #5 regions (#70)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix region handling & text marker positioning

* Refactor to update regions and cascade down to text markers, etc.

* Remove debug code

* Fix relatedLocation line-col suffix

* Fix location.region updating in the UI + cleanup

* Skip LineMarker creation for unit tests

* PR feedback

* Fix #24 clear markers on file load (#71)

* Update to SARIF SDK v2.0.0-csd.2.beta.2019-01-24.1 (#73)

* Update to SDK 01-09

* Update to SARIF SDK 2.0.0-csd.2.beta.2019-01-24.1

* Correct version of interop package
EasyRhinoMSFT added a commit that referenced this issue May 2, 2019
@EasyRhinoMSFT
Merge develop into master for v2.1 release (#77)
c45ae9a 
* Fix #41, #48, #49 (#52)

* Fix #28 and #46 error list item text (#51)

* Tinkering

* Fix #28 and #46

* Use VS 'category' column for result baseline state, if present (#62)

* Fix #28 and #56 (#59)

* Fix #28 and #56

* Add unit tests

* Revamp Stacks view (#61)

* Update Stacks UI, add VS-styled ComboBox template

* Add double-click navigate to stack frame location

* ListView color corrections

* Remove serializer settings object

* PR feedback

* Fix #6 #26 #29 #30 #63 (#64)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix #3 #4 #5 regions (#70)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix region handling & text marker positioning

* Refactor to update regions and cascade down to text markers, etc.

* Remove debug code

* Fix relatedLocation line-col suffix

* Fix location.region updating in the UI + cleanup

* Skip LineMarker creation for unit tests

* PR feedback

* Fix #24 clear markers on file load (#71)

* Update to SARIF SDK v2.0.0-csd.2.beta.2019-01-24.1 (#73)

* Update to SDK 01-09

* Update to SARIF SDK 2.0.0-csd.2.beta.2019-01-24.1

* Correct version of interop package

* Updates for SARIF v2.1 + VS 2019 (#76)
EasyRhinoMSFT added a commit that referenced this issue May 2, 2019
@EasyRhinoMSFT
Merge develop into master (#79)
c1c1f47 
* Fix #41, #48, #49 (#52)

* Fix #28 and #46 error list item text (#51)

* Tinkering

* Fix #28 and #46

* Use VS 'category' column for result baseline state, if present (#62)

* Fix #28 and #56 (#59)

* Fix #28 and #56

* Add unit tests

* Revamp Stacks view (#61)

* Update Stacks UI, add VS-styled ComboBox template

* Add double-click navigate to stack frame location

* ListView color corrections

* Remove serializer settings object

* PR feedback

* Fix #6 #26 #29 #30 #63 (#64)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix #3 #4 #5 regions (#70)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix region handling & text marker positioning

* Refactor to update regions and cascade down to text markers, etc.

* Remove debug code

* Fix relatedLocation line-col suffix

* Fix location.region updating in the UI + cleanup

* Skip LineMarker creation for unit tests

* PR feedback

* Fix #24 clear markers on file load (#71)

* Update to SARIF SDK v2.0.0-csd.2.beta.2019-01-24.1 (#73)

* Update to SDK 01-09

* Update to SARIF SDK 2.0.0-csd.2.beta.2019-01-24.1

* Correct version of interop package

* Updates for SARIF v2.1 + VS 2019 (#76)

* Update build.props (#78)
EasyRhinoMSFT added a commit that referenced this issue May 2, 2019
@EasyRhinoMSFT
Merge develop branch into master (#80)
ce28353 
* Fix #41, #48, #49 (#52)

* Fix #28 and #46 error list item text (#51)

* Tinkering

* Fix #28 and #46

* Use VS 'category' column for result baseline state, if present (#62)

* Fix #28 and #56 (#59)

* Fix #28 and #56

* Add unit tests

* Revamp Stacks view (#61)

* Update Stacks UI, add VS-styled ComboBox template

* Add double-click navigate to stack frame location

* ListView color corrections

* Remove serializer settings object

* PR feedback

* Fix #6 #26 #29 #30 #63 (#64)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix #3 #4 #5 regions (#70)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix region handling & text marker positioning

* Refactor to update regions and cascade down to text markers, etc.

* Remove debug code

* Fix relatedLocation line-col suffix

* Fix location.region updating in the UI + cleanup

* Skip LineMarker creation for unit tests

* PR feedback

* Fix #24 clear markers on file load (#71)

* Update to SARIF SDK v2.0.0-csd.2.beta.2019-01-24.1 (#73)

* Update to SDK 01-09

* Update to SARIF SDK 2.0.0-csd.2.beta.2019-01-24.1

* Correct version of interop package

* Updates for SARIF v2.1 + VS 2019 (#76)

* Update build.props (#78)

* Update source.extension.vsixmanifest
EasyRhinoMSFT added a commit that referenced this issue May 10, 2019
@EasyRhinoMSFT
Merge develop into master (#83)
b5a102c 
* Fix #41, #48, #49 (#52)

* Fix #28 and #46 error list item text (#51)

* Tinkering

* Fix #28 and #46

* Use VS 'category' column for result baseline state, if present (#62)

* Fix #28 and #56 (#59)

* Fix #28 and #56

* Add unit tests

* Revamp Stacks view (#61)

* Update Stacks UI, add VS-styled ComboBox template

* Add double-click navigate to stack frame location

* ListView color corrections

* Remove serializer settings object

* PR feedback

* Fix #6 #26 #29 #30 #63 (#64)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix #3 #4 #5 regions (#70)

* Silo file deets by run.instanceGuid

Blech.

* Silo errors by run.instanceGuid

* Update comment

* Rrefactor per-run to dictionary of data class instances

* Work in progress

* Fix #6 + cleanup

* Add Result.extensions unit test

* Cleanup

* Update CodeAnalysisResultManager.cs

* Change RunId to simple int

* Fix #63 + handle download failure

* Revert unneeded changes

* Fix region handling & text marker positioning

* Refactor to update regions and cascade down to text markers, etc.

* Remove debug code

* Fix relatedLocation line-col suffix

* Fix location.region updating in the UI + cleanup

* Skip LineMarker creation for unit tests

* PR feedback

* Fix #24 clear markers on file load (#71)

* Update to SARIF SDK v2.0.0-csd.2.beta.2019-01-24.1 (#73)

* Update to SDK 01-09

* Update to SARIF SDK 2.0.0-csd.2.beta.2019-01-24.1

* Correct version of interop package

* Updates for SARIF v2.1 + VS 2019 (#76)

* Update build.props (#78)

* Update source.extension.vsixmanifest

* Add safe nav op (#82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EasyRhinoMSFT EasyRhinoMSFT

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cfaucon @EasyRhinoMSFT