Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be possible to decorate class methods with @action() #38

Closed
smikula opened this issue Feb 23, 2017 · 0 comments · Fixed by #40
Closed

It should be possible to decorate class methods with @action() #38

smikula opened this issue Feb 23, 2017 · 0 comments · Fixed by #40
Assignees
@smikula

Comments

@smikula
Copy link
Contributor

smikula commented Feb 23, 2017

Satchel's action is basically a decorator, but it doesn't work to decorate class methods. For one thing, the reference to this inside the method will no longer refer to the class instance, and there may be other issues.
@smikula smikula self-assigned this Feb 23, 2017
This was referenced Feb 23, 2017
Closed
Merged
smikula added a commit that referenced this issue Feb 28, 2017
@smikula
Allow @action decorator on class methods (#40)
04243bf 
This fixes #38; @action can now be used as a decorator on class methods. Of course it still works the same way when wrapping a simple function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smikula smikula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow @action decorator on class methods microsoft/satcheljs
1 participant
@smikula