Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace correlation headers #74

Closed
letmaik opened this issue Jan 13, 2023 · 0 comments · Fixed by #79
Closed

Add trace correlation headers #74

letmaik opened this issue Jan 13, 2023 · 0 comments · Fixed by #79
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@letmaik
Copy link
Member

letmaik commented Jan 13, 2023

Tracing of requests across systems typically relies on HTTP headers to establish correlation ids.

There's https://www.w3.org/TR/trace-context/ which is seeing adoption but Microsoft historically also uses x-ms-client-request-id and x-ms-request-id.

For compatibility, we can start with x-ms-request-id/x-ms-client-request-id and include those in log messages. Later on we can add W3C Trace Context headers and eventually deprecate and then remove the x-ms-* headers.

@letmaik letmaik added the enhancement New feature or request label Jan 13, 2023
@letmaik letmaik added this to the 0.2.0 milestone Jan 16, 2023
@letmaik letmaik self-assigned this Jan 16, 2023
This was referenced Jan 16, 2023
letmaik added a commit that referenced this issue Jan 18, 2023
Closes #74 and #72.

Signed-off-by: Maik Riechert <maik.riechert@microsoft.com>
Co-authored-by: Paul Liétar <lietarpaul@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant