Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new GitHub action to run unit tests #146

Merged
merged 13 commits into from
Aug 28, 2023

Conversation

ivarprudnikov
Copy link
Member

@ivarprudnikov ivarprudnikov commented Aug 28, 2023

The main idea is to reduce the dependence on Azure resources and make sure tests are always run. A good example is a current Azure resource config which is difficult to setup due to the internal requirements and the nature of SGX. The resources were recently removed which stopped the tests from running even in virtual mode. Even though they are being added back in, we need to make sure the dependence is derisked.

New GitHub action:

  • Run a build in virtual mode
  • Run unit tests
  • Run functional tests
  • Check code formatting

@ivarprudnikov ivarprudnikov changed the title adds new github action to run unit tests Adds new GitHub action to run unit tests Aug 28, 2023
@ivarprudnikov ivarprudnikov enabled auto-merge (squash) August 28, 2023 12:36
Copy link
Member

@andpiccione andpiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/build-test-virtual.yml Show resolved Hide resolved
.github/workflows/build-test-virtual.yml Show resolved Hide resolved
@ivarprudnikov ivarprudnikov enabled auto-merge (squash) August 28, 2023 14:27
@ivarprudnikov ivarprudnikov merged commit 78fbbf6 into main Aug 28, 2023
6 checks passed
@ivarprudnikov ivarprudnikov deleted the feat/adds-github-ci-vitual-tests branch August 28, 2023 14:48
@ivarprudnikov ivarprudnikov added this to the 0.5.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants