Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Azure Pipelines pool #150

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Updated Azure Pipelines pool #150

merged 2 commits into from
Sep 6, 2023

Conversation

vimauro
Copy link
Member

@vimauro vimauro commented Sep 5, 2023

I have set up a new agent pool to be used by Azure Pipelines since the old one was removed.
This PR makes use of the new pool and restores the LOCUST_PEAK_USERS to 100 which is the original value while we investigate why 500 fails in SGX with no prefix tree.

Copy link
Member

@ivarprudnikov ivarprudnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a readme explaining how to setup the pipeline, there is a doc directory for this:

how to create a pool
how to link it in azure devops

Copy link
Member

@andpiccione andpiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

test/test_load.py Outdated Show resolved Hide resolved
Copy link
Member

@andpiccione andpiccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we now remove the GitHub action to run virtual tests, that we recently added? The full build should now cover everything and it seems repetitive to keep both just for reducing dependency on Azure.

@vimauro
Copy link
Member Author

vimauro commented Sep 5, 2023

Add a readme explaining how to setup the pipeline, there is a doc directory for this:

how to create a pool how to link it in azure devops

Those are msft internal instructions while Azure Pipelines is an App already installed at Organization level (https://github.com/apps/azure-pipelines)

@vimauro
Copy link
Member Author

vimauro commented Sep 5, 2023

Should we now remove the GitHub action to run virtual tests, that we recently added? The full build should now cover everything and it seems repetitive to keep both just for reducing dependency on Azure.

Makes sense to me. Thoughts @ivarprudnikov ?

@ivarprudnikov
Copy link
Member

ivarprudnikov commented Sep 5, 2023 via email

@vimauro vimauro enabled auto-merge (squash) September 6, 2023 10:54
@vimauro vimauro dismissed ivarprudnikov’s stale review September 6, 2023 10:57

Those are msft internal instructions while Azure Pipelines is an App already installed at Organization level (https://github.com/apps/azure-pipelines)

@vimauro vimauro merged commit f553a7c into main Sep 6, 2023
6 checks passed
@vimauro vimauro deleted the users/vimauro/update_az_pools branch September 6, 2023 10:57
@ivarprudnikov ivarprudnikov added this to the 0.5.0 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants