Update CCF constitution to be compatible with the new ccf.crypto package #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vimauro
approved these changes
Dec 19, 2023
andpiccione
deleted the
users/apiccione/update-ccf-constitution-compatibility
branch
|
LGTM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some of the latest CCF versions (>=5.0.0-dev0 and >=4.0.12), the
ccf.isValidX509CertBundlefunction was changed toccf.crypto.isValidX509CertBundle. This change caused some CCF apps (already at 4.0.12) to fail governance calls, since they didn't have an updated constitution compatible with the corresponding CCF version.This PR applies the same fix (i.e., make the constitution compatible with different CCF package versions) to the bundled SCITT constitution. This way, we avoid running into the same problem whenever we decide to upgrade SCITT to CCF 4.0.12 or higher.