Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CCF to 4.0.12 and add support for OpenSSL 3.x #173

Merged
merged 9 commits into from
Jan 9, 2024

Conversation

andpiccione
Copy link
Member

  • Update CCF version to 4.0.12
  • Fix unit tests after crypto library changes introduced in CCF 4.0.8 (due to the upgrade to OpenSSL 3.x)
  • Remove deprecated OpenSSL functions and add support for using OpenSSL 3.x in SGX builds based on CCF code changes

Copy link
Member

@vimauro vimauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM ! I took a look at CCF code as well to validate their changes.
Only a minor comment about the usage of this condition if !(defined(OPENSSL_VERSION_MAJOR) && OPENSSL_VERSION_MAJOR >= 3) . My personal preference (and only cosmetic afterall) is to invert the if-else conditions and use if defined(OPENSSL_VERSION_MAJOR) && OPENSSL_VERSION_MAJOR >= 3

@andpiccione andpiccione marked this pull request as ready for review January 9, 2024 12:56
@andpiccione andpiccione enabled auto-merge (squash) January 9, 2024 14:06
@andpiccione andpiccione merged commit d3b20b3 into main Jan 9, 2024
5 checks passed
@andpiccione andpiccione deleted the users/apiccione/feat/update-to-ccf-4.0.12 branch January 9, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants