Add support for Notary claims #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
reviewed
Jan 17, 2023
Co-authored-by: Paul Liétar <lietarpaul@microsoft.com>
letmaik
changed the title
plietar
reviewed
Jan 19, 2023
plietar
approved these changes
Jan 19, 2023
Signed-off-by: Maik Riechert <maik.riechert@microsoft.com>
plietar
reviewed
Jan 19, 2023
plietar
reviewed
Jan 19, 2023
|
|
||
| // alg, crit, cty, io.cncf.notary.signingScheme are required. | ||
|
|
||
| check_is_accepted_algorithm(phdr, configuration); |
There was a problem hiding this comment.
IMO this belongs to the generic verifier code path. All profiles are going to have an algorithm, and we should always enforce this.
There was a problem hiding this comment.
I'm open to be convinced about this, at the moment I think it's clearer for each profile to contain all of the validation it requires (including an initial call to do generic validation). Though I don't think it makes much difference either way.
plietar
reviewed
Jan 19, 2023
This was referenced Jan 20, 2023
Merged
darracott
added a commit
that referenced
this pull request
Jan 30, 2023
Implementing hangover review comments from #73 addressing #84 Featuring: - x5chain (de)serialization - QCBOR tweaks - Cleaning up redundant code - Notary spec allows x5chain in the protected header (but currently notation always puts it in the unprotected headers). We now check for the x5chain in the protected header of notary claims before the unprotected header. --------- Co-authored-by: Paul Liétar <lietarpaul@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows claims generated by
notationto be submitted to SCITT.Note:
crit. This PR brings back a lot of code to work around that limitation so that we can verify Notary claims' signatures without using t_cose.critthen we should remove the workaround code which is marked by comments stating the code is "Temporarily needed for notary_verify().".