Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Connectors - Memory - Unit test coverage #1598

Closed
markwallace-microsoft opened this issue Jun 20, 2023 · 1 comment
Closed

Java: Connectors - Memory - Unit test coverage #1598

markwallace-microsoft opened this issue Jun 20, 2023 · 1 comment
Assignees
@dsgrieve
Labels
java Issue or PR regarding Java code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@markwallace-microsoft
Copy link
Member

No description provided.

@markwallace-microsoft markwallace-microsoft added the java Issue or PR regarding Java code label Jun 20, 2023
@johnoliver johnoliver removed their assignment Jun 21, 2023
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Jun 21, 2023
This was referenced Jun 27, 2023
Closed
Merged
@dsgrieve
Copy link
Member

PR #1795

Note: This PR increases coverage of the memory API and has some basic tests of AzureCognitiveSearchMemory. I suggest that a separate issue and PR be created for increasing the coverage of AzureCognitiveSearchMemoryTests

johnoliver added a commit that referenced this issue Jul 5, 2023
@dsgrieve @Luigi96
@joebraley @markwallace-microsoft @johnoliver
Java: Connectors - Memory - Unit test coverage #1598 (#1795)
a1749f7 
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Java: Connectors - Memory - Unit test coverage #1598 

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Run unit tests with coverage and add additional tests to try to increase
coverage.
Added positive tests cases for AzureCognitiveSearchMemory. Negative
tests and coverage need to be addressed.
Because this is somewhat time consuming, I suggest that be done in a
separate PR rather than hold this PR.
I have created [Java: Increase coverage of
AzureCognitiveSearchMemoryTests
](https://github.com/microsoft/semantic-kernel/issues/1797) for that
purpose.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Luigi Montoya <yayodelta@gmail.com>
Co-authored-by: joe-braley <joebraley@microsoft.com>
Co-authored-by: Luigi96 <luiseduardom@microsoft.com>
Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com>
@d3r3kk d3r3kk closed this as completed Jul 5, 2023
This was referenced Aug 1, 2023
Closed
Closed
johnoliver added a commit to johnoliver/semantic-kernel that referenced this issue Jun 5, 2024
@dsgrieve @Luigi96
@joebraley @markwallace-microsoft @johnoliver
Java: Connectors - Memory - Unit test coverage microsoft#1598 (micros…
93f1773 
…oft#1795)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Java: Connectors - Memory - Unit test coverage microsoft#1598 

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Run unit tests with coverage and add additional tests to try to increase
coverage.
Added positive tests cases for AzureCognitiveSearchMemory. Negative
tests and coverage need to be addressed.
Because this is somewhat time consuming, I suggest that be done in a
separate PR rather than hold this PR.
I have created [Java: Increase coverage of
AzureCognitiveSearchMemoryTests
](https://github.com/microsoft/semantic-kernel/issues/1797) for that
purpose.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Luigi Montoya <yayodelta@gmail.com>
Co-authored-by: joe-braley <joebraley@microsoft.com>
Co-authored-by: Luigi96 <luiseduardom@microsoft.com>
Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com>
johnoliver added a commit to johnoliver/semantic-kernel that referenced this issue Jun 5, 2024
@dsgrieve @Luigi96
@joebraley @markwallace-microsoft @johnoliver
Java: Connectors - Memory - Unit test coverage microsoft#1598 (micros…
14fa32b 
…oft#1795)

### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Java: Connectors - Memory - Unit test coverage microsoft#1598 

### Description
<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->
Run unit tests with coverage and add additional tests to try to increase
coverage.
Added positive tests cases for AzureCognitiveSearchMemory. Negative
tests and coverage need to be addressed.
Because this is somewhat time consuming, I suggest that be done in a
separate PR rather than hold this PR.
I have created [Java: Increase coverage of
AzureCognitiveSearchMemoryTests
](https://github.com/microsoft/semantic-kernel/issues/1797) for that
purpose.

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [ x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Luigi Montoya <yayodelta@gmail.com>
Co-authored-by: joe-braley <joebraley@microsoft.com>
Co-authored-by: Luigi96 <luiseduardom@microsoft.com>
Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Co-authored-by: John Oliver <1615532+johnoliver@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsgrieve dsgrieve

Labels
java Issue or PR regarding Java code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
No open projects
Java Semantic Kernel
Status: Sprint: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@johnoliver @dsgrieve @d3r3kk @evchaki @markwallace-microsoft