Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: [HandlebarsPlanner] Handle case when schema and ParameterType can co-exist #4250

Closed
teresaqhoang opened this issue Dec 14, 2023 · 0 comments
Closed

.Net: [HandlebarsPlanner] Handle case when schema and ParameterType can co-exist #4250

teresaqhoang opened this issue Dec 14, 2023 · 0 comments
Assignees
@teresaqhoang
Labels
.NET Issue or Pull requests regarding .NET code planner Anything related to planner or plans sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Milestone
v1.0.0

Comments

@teresaqhoang
Copy link
Contributor

Schema and ParameterType can co-exist i.e., when ParameterType = RestApiResponse

  • Default to schema? Needs investigation on other response types from SK
@teresaqhoang teresaqhoang added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Dec 14, 2023
@teresaqhoang teresaqhoang added this to the v1.0.0 milestone Dec 14, 2023
@teresaqhoang teresaqhoang self-assigned this Dec 14, 2023
@teresaqhoang teresaqhoang changed the title [HandlebarsPlanner] Handle case when schema and ParameterType can co-exist i.e., when ParameterType = RestApiResponse [HandlebarsPlanner] Handle case when schema and ParameterType can co-exist Dec 14, 2023
@teresaqhoang teresaqhoang added the planner Anything related to planner or plans label Dec 14, 2023
@matthewbolanos matthewbolanos added the .NET Issue or Pull requests regarding .NET code label Jan 2, 2024
@github-actions github-actions bot changed the title [HandlebarsPlanner] Handle case when schema and ParameterType can co-exist .Net: [HandlebarsPlanner] Handle case when schema and ParameterType can co-exist Jan 2, 2024
@teresaqhoang teresaqhoang mentioned this issue Feb 26, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 26, 2024
@teresaqhoang
.Net: Tuning HB Planner - CreatePlan prompt, template extraction, and…
9a7dc1a 
… type handling (#5137)

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Resolves 
- #4751 
- #4250 
- #4721

This PR contains fixes for template extraction from model results;
handling case where schema and parameter type can co-exist; + prompt
tuning

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teresaqhoang teresaqhoang

Labels
.NET Issue or Pull requests regarding .NET code planner Anything related to planner or plans sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
v1.0.0
Development

No branches or pull requests
4 participants
@matthewbolanos @shawncal @teresaqhoang @markwallace-microsoft