Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Update Hugging Face connector #4947

Closed
markwallace-microsoft opened this issue Feb 9, 2024 · 0 comments · Fixed by #5075 or #5150
Closed

.Net: Update Hugging Face connector #4947

markwallace-microsoft opened this issue Feb 9, 2024 · 0 comments · Fixed by #5075 or #5150
Assignees
@RogerBarreto
Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Feb 9, 2024 •
edited by RogerBarreto

SK Hugging Face package should support the following:

  1. TextGeneration
  2. TextEmbedding
  3. ImageToText -> Blip Model

The connector implementation should include a generic client implementation and allow for the injection of custom HttpClients.
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code triage labels Feb 9, 2024
@markwallace-microsoft markwallace-microsoft added sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) and removed triage labels Feb 12, 2024
@RogerBarreto RogerBarreto mentioned this issue Feb 22, 2024
Merged
@RogerBarreto RogerBarreto linked a pull request Feb 22, 2024 that will close this issue
.Net Hugging Face HttpClient Connector Update #5075
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 23, 2024
@RogerBarreto @Krzysztof318
.Net Hugging Face HttpClient Connector Update (#5075)
316ff5d 
### Motivation and Context

Resolves Partially #4947 

Update Hugging Face connector segregating the responsibilities of the
TextGenerationService, TextEmbeddingService, HttpClient, JsonParsing,
EndPointResolving.

### Description

This enables paving the way to support additional Hugging Face
modalities

---------

Co-authored-by: Krzysztof Kasprowicz <60486987+Krzysztof318@users.noreply.github.com>
@RogerBarreto RogerBarreto mentioned this issue Feb 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
@RogerBarreto @Krzysztof318 @dmytrostruk
.Net ImageToText Abstraction + HuggingFace Connector ImageToText supp…
0e10dd5 
…ort. (#5150)

### Motivation and Context

Add support for a new modality Image -> Text including a Hugging Face
service for it.

Resolves #4947

---------

Co-authored-by: Krzysztof Kasprowicz <60486987+Krzysztof318@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RogerBarreto RogerBarreto

Labels
.NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
3 participants
@RogerBarreto @shawncal @markwallace-microsoft