Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Add Semantic-Kernel-Version header to Azure OpenAI requests for .NET #5037

Closed
matthewbolanos opened this issue Feb 15, 2024 · 0 comments · Fixed by #5048
Closed

.Net: Add Semantic-Kernel-Version header to Azure OpenAI requests for .NET #5037

matthewbolanos opened this issue Feb 15, 2024 · 0 comments · Fixed by #5048
Assignees
@markwallace-microsoft
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code triage

Comments

@matthewbolanos
Copy link
Member

To help with debugging, the requests to OpenAI should include a Semantic-Kernel-Version header with the value "dotnet/version-number"
@matthewbolanos matthewbolanos added the kernel Issues or pull requests impacting the core kernel label Feb 15, 2024
@shawncal shawncal added .NET Issue or Pull requests regarding .NET code triage labels Feb 15, 2024
@github-actions github-actions bot changed the title Add Semantic-Kernel-Version header to Azure OpenAI requests for .NET .Net: Add Semantic-Kernel-Version header to Azure OpenAI requests for .NET Feb 15, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2024
@markwallace-microsoft
.Net: Add new Semantic-Kernel-Version header to all HTTP requests (#5048
9a8c0be 
)

### Motivation and Context
Closes #5037 

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code triage
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
3 participants
@matthewbolanos @shawncal @markwallace-microsoft