Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Integrate SSE Parser for AIService streaming #5610

Closed
markwallace-microsoft opened this issue Mar 22, 2024 · 4 comments · Fixed by #5710
Closed

.Net: Integrate SSE Parser for AIService streaming #5610

markwallace-microsoft opened this issue Mar 22, 2024 · 4 comments · Fixed by #5710
Assignees
@markwallace-microsoft
Labels
ai connector Anything related to AI connectors .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@markwallace-microsoft
Copy link
Member

See: #5548 (comment)
@markwallace-microsoft markwallace-microsoft added triage sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) ai connector Anything related to AI connectors and removed sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) triage labels Mar 22, 2024
@markwallace-microsoft markwallace-microsoft self-assigned this Mar 22, 2024
Merged
4 tasks
@markwallace-microsoft markwallace-microsoft removed their assignment Mar 22, 2024
@stephentoub
Copy link
Member

@jeffhandley, @ericstj, fyi re dotnet/runtime#98105

@Krzysztof318
Copy link
Contributor

Krzysztof318 commented Mar 22, 2024 •
edited
Loading

Related to parser impl #5574

We can implement from azure SDK #5574 (comment)

@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Mar 22, 2024
@github-actions github-actions bot changed the title Implement SSE Parser for AIService streaming .Net: Implement SSE Parser for AIService streaming Mar 22, 2024
@markwallace-microsoft markwallace-microsoft changed the title .Net: Implement SSE Parser for AIService streaming .Net: Integrate SSE Parser for AIService streaming Mar 22, 2024
@markwallace-microsoft markwallace-microsoft self-assigned this Mar 22, 2024
@Krzysztof318
Copy link
Contributor

Krzysztof318 commented Mar 31, 2024 •
edited
Loading

@markwallace-microsoft I need specialized SSE parser for Claude 3, because claude utilizes events, not only data. So you can assign the issue to me and I take care for that.

@Krzysztof318 Krzysztof318 mentioned this issue Apr 1, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 3, 2024
@Krzysztof318 @RogerBarreto
.Net: Specialized SSE parser as Utility (#5710)
2ddb5ef 
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Closes #5610 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Specialized SSE parser implementation as internal utilities.

Code is partially borrowed from Azure sdk.

cc: @stephentoub @RogerBarreto @markwallace-microsoft 

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwallace-microsoft markwallace-microsoft

Labels
ai connector Anything related to AI connectors .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Semantic Kernel
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.Net: Specialized SSE parser as Utility Krzysztof318/semantic-kernel
4 participants
@stephentoub @Krzysztof318 @markwallace-microsoft and others