Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve copilot-sample-app exception handling when handling speechToken #689

Closed
cchighman opened this issue Apr 27, 2023 · 2 comments
Closed
Assignees

Comments

@cchighman
Copy link
Member

By default, the appsettings config leaves Region parameter blank for AzureSpeech.
image

The webapp makes a call by default to fetch a speech token.
image

No validation is in place and, because the param is blank by default, it will result in a malformed URL.
image

It's really a trivial thing for a sample app but perhaps a way I could contribute to help improve provided this sample app has been very helpful to get me going.

Is there any appetite to contribute back to the sample apps in efforts to improve experience ?

@evchaki
Copy link

evchaki commented Apr 27, 2023

@cchighman , thanks for catching this, we would love a PR to help catch this blank scenario. @amsacha

@amsacha
Copy link
Contributor

amsacha commented Apr 27, 2023

We merged in a fix for this 2 days ago, #652. But yes we would love contributions from the community.

@amsacha amsacha closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants