CopilotChat: Make Azure Speech optional on the backend and don't show errors when not configured on the frontend #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… errors when not configured on the frontent.
hathind-ms
previously approved these changes
Apr 25, 2023
adrianwyatt
added
bug
adrianwyatt
added
PR: ready to merge
amsacha
previously approved these changes
Apr 25, 2023
TaoChenOSU
previously approved these changes
Apr 25, 2023
adrianwyatt
dismissed stale reviews from TaoChenOSU, amsacha, and hathind-ms
via
5112402
hathind-ms
previously approved these changes
Apr 25, 2023
glahaye
reviewed
Apr 25, 2023
samples/apps/copilot-chat-app/webapi/Controllers/SpeechTokenController.cs
Outdated
Show resolved
Hide resolved
Vivihung
previously approved these changes
Apr 25, 2023
samples/apps/copilot-chat-app/webapi/Controllers/SpeechTokenController.cs
Outdated
Show resolved
Hide resolved
hathind-ms
approved these changes
Apr 25, 2023
dluc
pushed a commit
that referenced
this pull request
Apr 29, 2023
… errors when not configured on the frontend (#652) ### Motivation and Context Fix for failures when AzureSpeech is not configured. ### Description Made AzureSpeech options optional and return OK with a token response that is marked as not successful.
dehoward
pushed a commit
to lemillermicrosoft/semantic-kernel
that referenced
this pull request
Jun 1, 2023
… errors when not configured on the frontend (microsoft#652) ### Motivation and Context Fix for failures when AzureSpeech is not configured. ### Description Made AzureSpeech options optional and return OK with a token response that is marked as not successful.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
… errors when not configured on the frontend (microsoft#652) ### Motivation and Context Fix for failures when AzureSpeech is not configured. ### Description Made AzureSpeech options optional and return OK with a token response that is marked as not successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix for failures when AzureSpeech is not configured.
Description
Made AzureSpeech options optional and return OK with a token response that is marked as not successful.