You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SkillCollection duplicates its surface area, once for semantic functions and once for native functions. Why does SkillCollection care about the distinction at all? It ends up storing them all in the same dictionary, so it already doesn't support having two different functions with the same name, and in any scenario where a consumer cares to only get a semantic vs native function, they can just check the resulting function's IsSemantic (it's also not clear to me in what situation a consumer would actually care).
It's part of the journey from internal prototypes written a year ago when we first started using "AI functions". We're going through another set of design polish tasks and this was one of the TODO, there's a few PRs coming and a couple in particular touching this area.
SkillCollection duplicates its surface area, once for semantic functions and once for native functions. Why does SkillCollection care about the distinction at all? It ends up storing them all in the same dictionary, so it already doesn't support having two different functions with the same name, and in any scenario where a consumer cares to only get a semantic vs native function, they can just check the resulting function's IsSemantic (it's also not clear to me in what situation a consumer would actually care).
cc: @shawncal
The text was updated successfully, but these errors were encountered: