Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does SkillCollection differentiate semantic vs native in its APIs? #791

Closed
stephentoub opened this issue May 3, 2023 · 2 comments
Closed
Assignees

Comments

@stephentoub
Copy link
Member

stephentoub commented May 3, 2023

SkillCollection duplicates its surface area, once for semantic functions and once for native functions. Why does SkillCollection care about the distinction at all? It ends up storing them all in the same dictionary, so it already doesn't support having two different functions with the same name, and in any scenario where a consumer cares to only get a semantic vs native function, they can just check the resulting function's IsSemantic (it's also not clear to me in what situation a consumer would actually care).

cc: @shawncal

@evchaki
Copy link

evchaki commented May 4, 2023

@stephentoub thanks for bringing this up, we will take a look

@dluc
Copy link
Collaborator

dluc commented May 8, 2023

It's part of the journey from internal prototypes written a year ago when we first started using "AI functions". We're going through another set of design polish tasks and this was one of the TODO, there's a few PRs coming and a couple in particular touching this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants