Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify orchestration API #848

Merged
merged 1 commit into from May 8, 2023
Merged

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented May 7, 2023

Motivation and Context

Complete some early work from Feb, simplifying the orchestration API, removing redundant code in the function registry.

Description

Merge registry methods used for native and semantic functions, given that the underlying implementation was refactored and the distinction is not required anymore.

@dluc dluc added the PR: ready for review All feedback addressed, ready for reviews label May 7, 2023
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels May 7, 2023
@dluc dluc mentioned this pull request May 7, 2023
@stephentoub
Copy link
Member

Looks like this addresses #791. Thanks.

@dluc dluc force-pushed the dluc140skillcollection branch 3 times, most recently from e02b000 to 5afeb48 Compare May 8, 2023 23:24
@dluc
Copy link
Collaborator Author

dluc commented May 8, 2023

ready to go

@github-actions github-actions bot removed the samples label May 8, 2023
@shawncal shawncal enabled auto-merge (squash) May 8, 2023 23:49
@shawncal shawncal merged commit b88611f into microsoft:main May 8, 2023
9 checks passed
dehoward pushed a commit to lemillermicrosoft/semantic-kernel that referenced this pull request Jun 1, 2023
### Motivation and Context

Complete some early work from Feb, simplifying the orchestration API,
removing redundant code in the function registry.

### Description

Merge registry methods used for native and semantic functions, given
that the underlying implementation was refactored and the distinction is
not required anymore.
@dluc dluc deleted the dluc140skillcollection branch June 14, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants