Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authentication in notebook #1022

Merged
merged 3 commits into from
May 18, 2023
Merged

Fix authentication in notebook #1022

merged 3 commits into from
May 18, 2023

Conversation

riedgar-ms
Copy link
Contributor

Motivation and Context

Fix an authentication issue with the fourth Python notebook, by coping from one of the others.

Fixes #1021

Description

Copy/paste from another notebook

Contribution Checklist

@alexchaomander alexchaomander mentioned this pull request May 16, 2023
Closed
@alexchaomander alexchaomander self-requested a review May 16, 2023 21:50
alexchaomander
alexchaomander approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@alexchaomander alexchaomander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@riedgar-ms
Copy link
Contributor Author

Thank you for fixing this!

Did I miss a script I should have run to clean up the notebook?

@alexchaomander alexchaomander added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. python Pull requests for the Python Semantic Kernel labels May 17, 2023
@github-actions github-actions bot removed the python Pull requests for the Python Semantic Kernel label May 18, 2023
@shawncal shawncal merged commit a414592 into microsoft:main May 18, 2023
18 checks passed
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
@riedgar-ms
Fix authentication in notebook (microsoft#1022)
ece572f 
### Motivation and Context
Fix an authentication issue with the fourth Python notebook, by copying
from one of the others.

Fixes microsoft#1021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dluc dluc dluc left review comments

@alexchaomander alexchaomander alexchaomander approved these changes

@shawncal shawncal shawncal approved these changes

Assignees
No one assigned
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notebook '04-context-variables-chat' not working
4 participants
@riedgar-ms @dluc @alexchaomander @shawncal