Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring bash deployment scripts back up to date #1024

Merged
merged 4 commits into from May 17, 2023
Merged

Bring bash deployment scripts back up to date #1024

merged 4 commits into from May 17, 2023

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented May 16, 2023

Motivation and Context

The current bash deployment scripts are out of synch with the latest templates.

Description

  • Update the bash deployment scripts
  • Provide usage information

Contribution Checklist

@glahaye glahaye added the PR: ready for review All feedback addressed, ready for reviews label May 16, 2023
@glahaye glahaye requested a review from adrianwyatt May 16, 2023 21:39
@glahaye glahaye added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. and removed PR: ready for review All feedback addressed, ready for reviews labels May 16, 2023
@hathind-ms hathind-ms enabled auto-merge (squash) May 17, 2023 00:31
@hathind-ms hathind-ms merged commit 31be33b into microsoft:main May 17, 2023
19 checks passed
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
### Motivation and Context
The current bash deployment scripts are out of synch with the latest
templates.


### Description
- Update the bash deployment scripts
- Provide usage information


### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 馃槃

Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com>
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
The current bash deployment scripts are out of synch with the latest
templates.


### Description
- Update the bash deployment scripts
- Provide usage information


### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [ ] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 馃槃

Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Co-authored-by: Harleen Thind <39630244+hathind-ms@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants