Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit bot name refactor (modal flow) #1028

Merged
merged 3 commits into from
May 17, 2023

Conversation

teresaqhoang
Copy link
Contributor

Motivation and Context

This PR implements a new modal design for Edit Chatbot name experience. It also enabled Save on "Enter" down for accessibility.

image

@teresaqhoang teresaqhoang changed the title Edit botname Edit bot name refactor (modal flow) May 16, 2023
@teresaqhoang teresaqhoang added PR: ready for review All feedback addressed, ready for reviews typescript labels May 16, 2023
@hathind-ms hathind-ms enabled auto-merge (squash) May 17, 2023 00:03
@hathind-ms hathind-ms merged commit 4c2f94a into microsoft:main May 17, 2023
18 checks passed
@teresaqhoang teresaqhoang deleted the edit-botname branch May 18, 2023 20:43
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

This PR implements a new modal design for Edit Chatbot name experience.
It also enabled Save on "Enter" down for accessibility.


![image](https://github.com/microsoft/semantic-kernel/assets/125500434/df3c1c88-9d71-4455-a05a-2cc4198d2234)
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context
<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

This PR implements a new modal design for Edit Chatbot name experience.
It also enabled Save on "Enter" down for accessibility.


![image](https://github.com/microsoft/semantic-kernel/assets/125500434/df3c1c88-9d71-4455-a05a-2cc4198d2234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants