CopilotChat: Combine AIOptions into a common setting. #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
hathind-ms
reviewed
May 17, 2023
adrianwyatt
added
docs and tests
This comment was marked as resolved.
This comment was marked as resolved.
adrianwyatt
added
PR: ready for review
gitri-ms
requested changes
May 18, 2023
hathind-ms
reviewed
May 18, 2023
samples/apps/copilot-chat-app/webapi/DeploymentTemplates/main.bicep
Outdated
Show resolved
Hide resolved
gitri-ms
reviewed
May 18, 2023
gitri-ms
reviewed
May 18, 2023
gitri-ms
reviewed
May 18, 2023
hathind-ms
approved these changes
May 18, 2023
amsacha
approved these changes
May 18, 2023
gitri-ms
approved these changes
May 18, 2023
5 tasks
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
### Motivation and Context Configuring AI service options in CopilotChat required 3 separate sections that are all identical. This change combines those section into a single section that shares the type (Azure/OpenAI), endpoint, and API key. ### Description - Removed "Completion", "Embedding", and "Planner:AIService" from settings - Added "AIService" sections containing all previous sections and a "Models" section to define models to use for completions, embeddings, and planning - Added a "config.ps1" script to set the API key as a user-secret and generate an 'appsettings.Development.json' with AIService overrides.
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context Configuring AI service options in CopilotChat required 3 separate sections that are all identical. This change combines those section into a single section that shares the type (Azure/OpenAI), endpoint, and API key. ### Description - Removed "Completion", "Embedding", and "Planner:AIService" from settings - Added "AIService" sections containing all previous sections and a "Models" section to define models to use for completions, embeddings, and planning - Added a "config.ps1" script to set the API key as a user-secret and generate an 'appsettings.Development.json' with AIService overrides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Configuring AI service options in CopilotChat required 3 separate sections that are all identical. This change combines those section into a single section that shares the type (Azure/OpenAI), endpoint, and API key.
Description