Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit README sample code error in dotnet #1038

Merged
merged 2 commits into from
May 18, 2023

Conversation

Masumi-M
Copy link
Contributor

Motivation and Context

  1. Why is this change required?
    => There was a bug in README file, and it may confuse for beginners.
  2. What problem does it solve?
    => The sample code in dotnet code.
  3. What scenario does it contribute to?
    => When the beginner try to execute code using README.
  4. If it fixes an open issue, please link to the issue here.
    => README Sample Code Error in dotnet聽#1037

Description

The following code are changed.

kernel.Config.AddOpenAITextCompletionService("davinci-openai",
    "text-davinci-003",               // OpenAI Model name
    "...your OpenAI API Key..."       // OpenAI API Key
);
kernel.Config.AddOpenAITextCompletionService(
    "text-davinci-003",               // OpenAI Model name
    "...your OpenAI API Key..."       // OpenAI API Key
);

Contribution Checklist

@dluc dluc enabled auto-merge (squash) May 18, 2023 21:09
@dluc dluc merged commit faf76e1 into microsoft:main May 18, 2023
18 checks passed
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
### Motivation and Context
1. Why is this change required?
=> There was a bug in README file, and it may confuse for beginners.
2. What problem does it solve?
=> The sample code in dotnet code.
3. What scenario does it contribute to?
=> When the beginner try to execute code using README.
4. If it fixes an open issue, please link to the issue here.
=> microsoft#1037

### Description
The following code are changed.
```cs:before
kernel.Config.AddOpenAITextCompletionService("davinci-openai",
    "text-davinci-003",               // OpenAI Model name
    "...your OpenAI API Key..."       // OpenAI API Key
);
```
```cs:after
kernel.Config.AddOpenAITextCompletionService(
    "text-davinci-003",               // OpenAI Model name
    "...your OpenAI API Key..."       // OpenAI API Key
);
```

Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants