Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Remaining R# Warnings + Task Error (.net 7) #1041

Merged
merged 7 commits into from
May 19, 2023
Merged

Fix Remaining R# Warnings + Task Error (.net 7) #1041

merged 7 commits into from
May 19, 2023

Conversation

RogerBarreto
Copy link
Member

Motivation and Context

Reduced the amount of warnings given in the project, still some related to namespace and name convention.

Contribution Checklist

@RogerBarreto RogerBarreto added the .NET Issue or Pull requests regarding .NET code label May 17, 2023
@github-actions github-actions bot added kernel Issues or pull requests impacting the core kernel kernel.core labels May 17, 2023
adrianwyatt
adrianwyatt previously approved these changes May 17, 2023
View reviewed changes
@adrianwyatt adrianwyatt enabled auto-merge (squash) May 19, 2023 00:52
@github-actions github-actions bot removed kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code labels May 19, 2023
@adrianwyatt adrianwyatt added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label May 19, 2023
@adrianwyatt adrianwyatt self-assigned this May 19, 2023
@lemillermicrosoft
Copy link
Member

Looks like this was already done in a different PR. Closing.

auto-merge was automatically disabled May 19, 2023 06:56

Pull request was closed

@RogerBarreto RogerBarreto reopened this May 19, 2023
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel samples labels May 19, 2023
@RogerBarreto RogerBarreto mentioned this pull request May 19, 2023
Closed
5 tasks
lemillermicrosoft
lemillermicrosoft approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@lemillermicrosoft lemillermicrosoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Title should be updated

@RogerBarreto RogerBarreto changed the title CoPilotChatWebApi - Fix some R# Warnings Fix Remaining R# Warnings + Task Error (.net 7) May 19, 2023
@lemillermicrosoft lemillermicrosoft merged commit 377b5f2 into microsoft:main May 19, 2023
18 checks passed
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
@RogerBarreto
Fix Remaining R# Warnings + Task Error (.net 7) (microsoft#1041)
ad58ea6 
### Motivation and Context
Reduced the amount of warnings given in the project, still some related
to namespace and name convention.
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@RogerBarreto
Fix Remaining R# Warnings + Task Error (.net 7) (microsoft#1041)
03e4986 
### Motivation and Context
Reduced the amount of warnings given in the project, still some related
to namespace and name convention.
@RogerBarreto RogerBarreto deleted the hotfixes/fix-rsharp-warnings branch December 5, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemillermicrosoft lemillermicrosoft lemillermicrosoft approved these changes

@adrianwyatt adrianwyatt adrianwyatt left review comments

Assignees

@adrianwyatt adrianwyatt

Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RogerBarreto @lemillermicrosoft @adrianwyatt