Clean up InternalsVisibleTo, add "Publish" target #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
.NET
shawncal
changed the title
shawncal
added
the
PR: ready for review
shawncal
requested review from
dluc,
SergeyMenshykh,
lemillermicrosoft and
adrianwyatt
lemillermicrosoft
approved these changes
May 18, 2023
lemillermicrosoft
added
the
PR: ready to merge
shawncal
force-pushed
the
strongname-cleanup
branch
from
aab55b8
to
c70948c
Compare
shawncal
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
### Description Removing unneeded PublicKey property on InternalsVisibleTo, and custom implementation of InternalsVisibleTo tag, as neither are needed. Added a new build configuration "Publish" that includes only the shipping SDK projects. When setting configuration=Publish, sample apps are excluded, and test projects are built but continue to target Release. Only the assemblies under "/bin/Publish" are signed and packed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing unneeded PublicKey property on InternalsVisibleTo, and custom implementation of InternalsVisibleTo tag, as neither are needed.
Added a new build configuration "Publish" that includes only the shipping SDK projects. When setting configuration=Publish, sample apps are excluded, and test projects are built but continue to target Release. Only the assemblies under "/bin/Publish" are signed and packed.
Contribution Checklist
dotnet format