Improvements to SKFunction interface #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dluc
commented
May 18, 2023
dluc
commented
- Allow to call functions passing a string. This is a common scenario, particularly with demos, allowing for a shorter syntax. The code logs a warning if the input string exists also in the context and is different.
- Add SKContext.Clone and delete unnecessary/redundant SKFunction.InvokeWithCustomInput method.
- Allow to create a context with a non empty cancellation token. This can be useful to inject an existing token from outside.
- Fix SKFunction invoke, allow to pass memory reference.
github-actions
bot
added
.NET
dluc
force-pushed
the
dluc157ifaces
branch
2 times, most recently
from
5ca6c5a
to
8065d99
Compare
stephentoub
reviewed
May 18, 2023
dotnet/src/SemanticKernel.Abstractions/SkillDefinition/ISKFunction.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 18, 2023
dotnet/src/SemanticKernel/Orchestration/CancellationTokenExtensions.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
May 18, 2023
stephentoub
reviewed
May 18, 2023
dluc
force-pushed
the
dluc157ifaces
branch
3 times, most recently
from
0deb536
to
784df46
Compare
shawncal
reviewed
May 18, 2023
dluc
force-pushed
the
dluc157ifaces
branch
2 times, most recently
from
48cee92
to
636fc38
Compare
shawncal
reviewed
May 19, 2023
dotnet/src/SemanticKernel/Orchestration/CombinedCancellationToken.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel/SkillDefinition/SKFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel/SkillDefinition/SKFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel/SkillDefinition/SKFunctionExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel/Orchestration/CancellationTokenExtensions.cs
Outdated
Show resolved
Hide resolved
dluc
force-pushed
the
dluc157ifaces
branch
3 times, most recently
from
c1abe16
to
44caf1f
Compare
lemillermicrosoft
added
PR: in progress
dluc
force-pushed
the
dluc157ifaces
branch
2 times, most recently
from
dc732fa
to
713ad12
Compare
* Allow to create a context with a non empty cancellation token * Fix SKFunction invoke, allow to pass memory reference * Delete unnecessary SKFunction.InvokeWithCustomInput
shawncal
approved these changes
May 19, 2023
shawncal
approved these changes
May 19, 2023
shawncal
added
the
PR: ready to merge
shawncal
pushed a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
* Allow to call functions passing a string. This is a common scenario, particularly with demos, allowing for a shorter syntax. The code logs a warning if the input string exists also in the context and is different. * Add SKContext.Clone and delete unnecessary/redundant SKFunction.InvokeWithCustomInput method. * Allow to create a context with a non empty cancellation token. This can be useful to inject an existing token from outside. * Fix SKFunction invoke, allow to pass memory reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.