Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests to reproduce BadRequest issue #1061

Merged

Conversation

kaza
Copy link
Contributor

@kaza kaza commented May 18, 2023

Motivation and Context

This PR provides integration tests to reproduce the issue #1050

Description

Contribution Checklist

@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels May 18, 2023
@lemillermicrosoft
Copy link
Member

Confirmed that CanUseOpenAiChatForTextCompletionAsync fails at current HEAD and updating with main shows it passing since the fix has been checked in. @RogerBarreto I will leave up to you if we want to add these/other additional tests (forgot what you added already). Otherwise we can probably close this. Thank you for the help @kaza

@RogerBarreto
Copy link
Member

My Fix #1062 resolved the problem with issue. #1061

Closes #1061
Resolves #1061

I Liked the integration test added in this PR and moved to the suite of tests beside the existing ones for OpenAI.

image

Copy link
Member

@RogerBarreto RogerBarreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the test to the OpenAI suite using a input parameter scenario.

Removed the others.

I liked the idea of having tests covering the Samples, that make sense to have a dedicated IT just ensuring all possible the samples works.

@lemillermicrosoft lemillermicrosoft merged commit 00a858e into microsoft:main May 19, 2023
18 checks passed
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
### Motivation and Context
This PR provides integration tests to reproduce the issue
microsoft#1050

### Description
These notes will help understanding how your code works. Thanks! -->

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
@kaza kaza deleted the issue-azurecompletion-semantic-400 branch May 21, 2023 07:12
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
### Motivation and Context
This PR provides integration tests to reproduce the issue
microsoft#1050

### Description
These notes will help understanding how your code works. Thanks! -->

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants