UX: Fix preview wrap in chatlistitem #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vivihung
added
bug
teresaqhoang
approved these changes
May 18, 2023
|
Can we also set min width on chat list item as well? |
hathind-ms
approved these changes
May 18, 2023
@hathind-ms it's already set in the root styles |
adrianwyatt
approved these changes
May 18, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
### Motivation and Context The preview text wrap causes the ChatListItem changes its height if the latest message is longer than the previous one. It results in instability of the UI. <img width="591" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/4814277/32f52f71-f670-4859-94a0-84dd5d8616f0"> ### Description * Prevent the preview text from wrapping by setting the display to 'block' and applying 'no-wrap' and ellipsis * Remove styles that are not in-use. After the fix: <img width="215" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/4814277/d5ff5e8f-2935-4a8c-b108-4f03f0edb592">
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context The preview text wrap causes the ChatListItem changes its height if the latest message is longer than the previous one. It results in instability of the UI. <img width="591" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/4814277/32f52f71-f670-4859-94a0-84dd5d8616f0"> ### Description * Prevent the preview text from wrapping by setting the display to 'block' and applying 'no-wrap' and ellipsis * Remove styles that are not in-use. After the fix: <img width="215" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/4814277/d5ff5e8f-2935-4a8c-b108-4f03f0edb592">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The preview text wrap causes the ChatListItem changes its height if the latest message is longer than the previous one. It results in instability of the UI.
Description
After the fix:
Contribution Checklist
[ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified withdotnet format[ ] All unit tests pass, and I have added new tests where possible