-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontloading chat on UploadBot + fixing chatlist timestamps #1070
Merged
adrianwyatt
merged 3 commits into
microsoft:main
from
teresaqhoang:chat-list-ordering-bug-fix
May 18, 2023
Merged
Frontloading chat on UploadBot + fixing chatlist timestamps #1070
adrianwyatt
merged 3 commits into
microsoft:main
from
teresaqhoang:chat-list-ordering-bug-fix
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hathind-ms
previously approved these changes
May 18, 2023
teresaqhoang
added
PR: ready to merge
PR has been approved by all reviewers, and is ready to merge.
typescript
labels
May 18, 2023
Vivihung
previously approved these changes
May 18, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/BotController.cs
Show resolved
Hide resolved
adrianwyatt
reviewed
May 18, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/BotController.cs
Show resolved
Hide resolved
amsacha
previously approved these changes
May 18, 2023
adrianwyatt
requested changes
May 18, 2023
samples/apps/copilot-chat-app/webapi/CopilotChat/Controllers/BotController.cs
Show resolved
Hide resolved
teresaqhoang
dismissed stale reviews from amsacha, Vivihung, and hathind-ms
via
May 18, 2023 19:05
b5973f0
adrianwyatt
approved these changes
May 18, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…t#1070) ### Motivation and Context This PR fixes a couple bugs. Now. - On UploadBot, new chats are automatically opened and selected at the top of chat list - Timestamps in chatlist show date if not same day - Fixed ChatHistory user rendering ![image](https://github.com/microsoft/semantic-kernel/assets/125500434/f6c9c203-e38e-4116-b5b3-451f362a621c) ### Description Other changes - Setting selectedId on addConversation so dev doesn't have to remember to do this every time - bot/upload returns 201 Create with new chat session details (previously 202 Accepted) - Reverse list of chats on API response instead of in loadChats
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…t#1070) ### Motivation and Context This PR fixes a couple bugs. Now. - On UploadBot, new chats are automatically opened and selected at the top of chat list - Timestamps in chatlist show date if not same day - Fixed ChatHistory user rendering ![image](https://github.com/microsoft/semantic-kernel/assets/125500434/f6c9c203-e38e-4116-b5b3-451f362a621c) ### Description Other changes - Setting selectedId on addConversation so dev doesn't have to remember to do this every time - bot/upload returns 201 Create with new chat session details (previously 202 Accepted) - Reverse list of chats on API response instead of in loadChats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes a couple bugs. Now.
Description
Other changes
Contribution Checklist
dotnet format