Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontloading chat on UploadBot + fixing chatlist timestamps #1070

Merged
merged 3 commits into from May 18, 2023

Conversation

teresaqhoang
Copy link
Contributor

@teresaqhoang teresaqhoang commented May 18, 2023

Motivation and Context

This PR fixes a couple bugs. Now.

  • On UploadBot, new chats are automatically opened and selected at the top of chat list
  • Timestamps in chatlist show date if not same day
  • Fixed ChatHistory user rendering
    image

Description

Other changes

  • Setting selectedId on addConversation so dev doesn't have to remember to do this every time
  • bot/upload returns 201 Create with new chat session details (previously 202 Accepted)
  • Reverse list of chats on API response instead of in loadChats

Contribution Checklist

hathind-ms
hathind-ms previously approved these changes May 18, 2023
@teresaqhoang teresaqhoang added PR: ready to merge PR has been approved by all reviewers, and is ready to merge. typescript labels May 18, 2023
amsacha
amsacha previously approved these changes May 18, 2023
@adrianwyatt adrianwyatt merged commit 120e400 into microsoft:main May 18, 2023
19 checks passed
@teresaqhoang teresaqhoang deleted the chat-list-ordering-bug-fix branch May 18, 2023 20:43
shawncal pushed a commit to johnoliver/semantic-kernel that referenced this pull request May 19, 2023
…t#1070)

### Motivation and Context
This PR fixes a couple bugs. Now.
- On UploadBot, new chats are automatically opened and selected at the
top of chat list
- Timestamps in chatlist show date if not same day
- Fixed ChatHistory user rendering 

![image](https://github.com/microsoft/semantic-kernel/assets/125500434/f6c9c203-e38e-4116-b5b3-451f362a621c)

### Description
Other changes
- Setting selectedId on addConversation so dev doesn't have to remember
to do this every time
- bot/upload returns 201 Create with new chat session details
(previously 202 Accepted)
- Reverse list of chats on API response instead of in loadChats
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
…t#1070)

### Motivation and Context
This PR fixes a couple bugs. Now.
- On UploadBot, new chats are automatically opened and selected at the
top of chat list
- Timestamps in chatlist show date if not same day
- Fixed ChatHistory user rendering 

![image](https://github.com/microsoft/semantic-kernel/assets/125500434/f6c9c203-e38e-4116-b5b3-451f362a621c)

### Description
Other changes
- Setting selectedId on addConversation so dev doesn't have to remember
to do this every time
- bot/upload returns 201 Create with new chat session details
(previously 202 Accepted)
- Reverse list of chats on API response instead of in loadChats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: ready to merge PR has been approved by all reviewers, and is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants