-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling API key auth in Copilot FE #1072
Enabling API key auth in Copilot FE #1072
Conversation
samples/apps/copilot-chat-app/webapp/src/libs/services/BaseService.ts
Outdated
Show resolved
Hide resolved
…ng/semantic-kernel into adding-api-key-to-env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change the name of the header we look for on the backend side in this line:
semantic-kernel/samples/apps/copilot-chat-app/webapi/Auth/ApiKeyAuthenticationHandler.cs
Line 20 in c89243a
public const string ApiKeyHeaderName = "x-api-key"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there is one more reference to x-api-key (as opposed to x-sk-api-key) in the README.
Could you change that too?
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PRs adds a new variable to the .env file called SK_API_KEY. If it is present and not blank, pass its value with all requests to the Semantic Kernel server as the value of a header named `x-sk-api-key` ![image](https://github.com/microsoft/semantic-kernel/assets/125500434/04859260-1b99-4554-98f0-93ba568297ef) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PRs adds a new variable to the .env file called SK_API_KEY. If it is present and not blank, pass its value with all requests to the Semantic Kernel server as the value of a header named `x-sk-api-key` ![image](https://github.com/microsoft/semantic-kernel/assets/125500434/04859260-1b99-4554-98f0-93ba568297ef) ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [X] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Motivation and Context
This PRs adds a new variable to the .env file called SK_API_KEY.
If it is present and not blank, pass its value with all requests to the Semantic Kernel server as the value of a header named
x-sk-api-key
Contribution Checklist
dotnet format