UX: Fix alignment in chat message #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vivihung
added
bug
Vivihung
changed the title
hathind-ms
previously approved these changes
May 18, 2023
teresaqhoang
previously approved these changes
May 18, 2023
reordering imports from merge conflicts
teresaqhoang
approved these changes
May 18, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
### Motivation and Context The message user name and timestamp alignment is off in the chat history item. <img width="1089" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/4814277/b7d6e644-ed53-4848-84ee-65d90519fe77"> Left: The current rendering Right: The expected result. ### Description * Replace HTML tag from Label to Text (span) for semantic reasons. * Label sets the wong line-height that causes the problem. Replacing it with Text fix the alignment. * Manually add font-size and weight styles back because they were covered by Label size property. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) ~- [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ ~- [ ] All unit tests pass, and I have added new tests where possible~ - [x] I didn't break anyone 馃槃 --------- Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Motivation and Context The message user name and timestamp alignment is off in the chat history item. <img width="1089" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/4814277/b7d6e644-ed53-4848-84ee-65d90519fe77"> Left: The current rendering Right: The expected result. ### Description * Replace HTML tag from Label to Text (span) for semantic reasons. * Label sets the wong line-height that causes the problem. Replacing it with Text fix the alignment. * Manually add font-size and weight styles back because they were covered by Label size property. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) ~- [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format`~ ~- [ ] All unit tests pass, and I have added new tests where possible~ - [x] I didn't break anyone 馃槃 --------- Co-authored-by: Teresa Hoang <125500434+teresaqhoang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The message user name and timestamp alignment is off in the chat history item.
Left: The current rendering
Right: The expected result.
Description
Contribution Checklist
- [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified withdotnet format- [ ] All unit tests pass, and I have added new tests where possible