Fix MIME type console error and enable WebApp production build #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teresaqhoang
changed the title
teresaqhoang
added
the
PR: ready for review
glahaye
approved these changes
May 19, 2023
shawncal
pushed a commit
to johnoliver/semantic-kernel
that referenced
this pull request
May 19, 2023
…soft#1085) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR fixes the MIME Type error we were seeing in the console and adds details for running a production build. Currently, we have the WebApp wrapped in React.StrictMode, which enables additional development behaviors, including rendering the App.tsx component twice to find bugs caused by impure rendering. Since StrictMode is development only, serving a production build of the WebApp avoids double rendering the app, so wanted to provide it as an option for developers. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> MIME type error we were observing:  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
…soft#1085) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR fixes the MIME Type error we were seeing in the console and adds details for running a production build. Currently, we have the WebApp wrapped in React.StrictMode, which enables additional development behaviors, including rendering the App.tsx component twice to find bugs caused by impure rendering. Since StrictMode is development only, serving a production build of the WebApp avoids double rendering the app, so wanted to provide it as an option for developers. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> MIME type error we were observing:  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [ ] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes the MIME Type error we were seeing in the console and adds details for running a production build.
Currently, we have the WebApp wrapped in React.StrictMode, which enables additional development behaviors, including rendering the App.tsx component twice to find bugs caused by impure rendering. Since StrictMode is development only, serving a production build of the WebApp avoids double rendering the app, so wanted to provide it as an option for developers.
Description
MIME type error we were observing:
Contribution Checklist
dotnet format