Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade .NET notebooks to latest nuget #1089

Merged
merged 2 commits into from May 19, 2023
Merged

Upgrade .NET notebooks to latest nuget #1089

merged 2 commits into from May 19, 2023

Conversation

dluc
Copy link
Collaborator

@dluc dluc commented May 19, 2023 •
edited

  • Upgrade to latest nuget, remove service ID
  • Simplify initial book to avoid redundant settings and information about the AI credentials
  • Change from kernel.RunAsync to function.InvokeAsync
  • align chat code across notebooks

@dluc dluc added the PR: ready for review All feedback addressed, ready for reviews label May 19, 2023
@github-actions github-actions bot added .NET Issue or Pull requests regarding .NET code samples labels May 19, 2023
@alexchaomander alexchaomander self-requested a review May 19, 2023 14:39
alexchaomander
alexchaomander approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@alexchaomander alexchaomander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. What's the guidance in C# moving forward for RunAsync vs InvokeAsync? Should people ever use RunAsync?

@lemillermicrosoft lemillermicrosoft enabled auto-merge (squash) May 19, 2023 18:18
@lemillermicrosoft lemillermicrosoft merged commit ac6869f into microsoft:main May 19, 2023
18 checks passed
This was referenced May 19, 2023
Closed
Closed
Closed
@dluc dluc deleted the dluc158notebooks branch June 14, 2023 01:14
shawncal pushed a commit to shawncal/semantic-kernel that referenced this pull request Jul 6, 2023
@dluc @lemillermicrosoft
Upgrade .NET notebooks to latest nuget (microsoft#1089)
79be42a 
* Upgrade to latest nuget, remove service ID
* Simplify initial book to avoid redundant settings and information
about the AI credentials
* Change from kernel.RunAsync to function.InvokeAsync
* align chat code across notebooks

Co-authored-by: Lee Miller <lemiller@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexchaomander alexchaomander alexchaomander approved these changes

Assignees
No one assigned
Labels
.NET Issue or Pull requests regarding .NET code PR: ready for review All feedback addressed, ready for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dluc @alexchaomander @lemillermicrosoft