Copilot Chat - Analyzers, detach from dotnet props #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
force-pushed
the
copilotchat-analyzers
branch
3 times, most recently
from
87d292c
to
ab8f1dc
Compare
shawncal
force-pushed
the
copilotchat-analyzers
branch
from
ab8f1dc
to
1eacc55
Compare
lemillermicrosoft
approved these changes
May 19, 2023
lemillermicrosoft
added
PR: ready for review
|
Let's wait for @adrianwyatt @TaoChenOSU or @hathind-ms to approve. This one's for you folks, so if you're happy with it, go ahead and merge. |
adrianwyatt
approved these changes
May 19, 2023
shawncal
added a commit
to shawncal/semantic-kernel
that referenced
this pull request
Jul 6, 2023
### Description Removing Copilot Chat's import of the /dotnet/ folder's common props: ``` <Import Project="$(RepoRoot)/dotnet/Directory.Build.targets" /> <Import Project="$(RepoRoot)/dotnet/Directory.Build.props" /> ``` This allows the project folder to be copied out of the repo and run independently. Adding the useful props to Copilot Chat's csproj file. Adding the analyzers in use by dotnet, and fixing style violations they pick up. (Note: these analyzers are optional and can be added/removed in Copilot Chat without affecting the rest of the repo).
golden-aries
pushed a commit
to golden-aries/semantic-kernel
that referenced
this pull request
Oct 10, 2023
### Description Removing Copilot Chat's import of the /dotnet/ folder's common props: ``` <Import Project="$(RepoRoot)/dotnet/Directory.Build.targets" /> <Import Project="$(RepoRoot)/dotnet/Directory.Build.props" /> ``` This allows the project folder to be copied out of the repo and run independently. Adding the useful props to Copilot Chat's csproj file. Adding the analyzers in use by dotnet, and fixing style violations they pick up. (Note: these analyzers are optional and can be added/removed in Copilot Chat without affecting the rest of the repo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing Copilot Chat's import of the /dotnet/ folder's common props:
This allows the project folder to be copied out of the repo and run independently.
Adding the useful props to Copilot Chat's csproj file. Adding the analyzers in use by dotnet, and fixing style violations they pick up. (Note: these analyzers are optional and can be added/removed in Copilot Chat without affecting the rest of the repo).
Contribution Checklist
dotnet format