Revise Embedding types' IsSupported and add vector ownership ctor #1093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #568
Description
Consolidate IsSupported to just being on the static Embedding type. And add a ctor to Embedding that allows transferring an array rather than copying it, then use that ctor in a bunch of places where we deserialize a vector and then immediately hand it off to an embedding. (I think subsequently we should think about getting rid of this ctor and just having the single ctor store rather than copy the original... I don't think the semi-immutability buys us much here.)
Contribution Checklist
dotnet format